Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 16 Jul 2020 14:54:50 +0800 | Subject | Re: [PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h |
| |
On Thu, Jul 16, 2020 at 2:24 PM Vinod Koul <vkoul@kernel.org> wrote: > > Driver uses GPIO functions but doesn't include the header explcitly. Add > that to fix build errors when GPIOLIB is disabled. > > drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit > declaration of function ‘gpiod_get_value_cansleep’; did you mean > ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit > declaration of function ‘devm_gpiod_get_optional’; did you mean > ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ > undeclared (first use in this function); did you mean ‘GPIOF_IN’? > drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit > declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? > [-Werror=implicit-function-declaration] > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
Maybe add
Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy") ?
Though it probably doesn't apply cleanly on the oldest stable kernel due to the extcon-provider header.
Either way,
Acked-by: Chen-Yu Tsai <wens@csie.org>
| |