Messages in this thread | | | Subject | Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies | From | Luca Ceresoli <> | Date | Thu, 16 Jul 2020 08:50:03 +0200 |
| |
Hi Sowjanya,
On 15/07/20 06:24, Sowjanya Komatineni wrote: > This patch adds IMX274 optional external clock input and voltage > supplies to device tree bindings. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > index 80f2e89..ee427f5 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > @@ -13,6 +13,11 @@ Required Properties: > > Optional Properties: > - reset-gpios: Sensor reset GPIO > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk".
Not sure where the "xclk" name comes from, the datasheet I have calls the pin "CKIN". Maybe using the same name as the datasheet is better?
Other than that looks good.
-- Luca
| |