Messages in this thread Patch in this message | | | From | Sergey Organov <> | Subject | [PATCH net-next v2 4/4] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() | Date | Wed, 15 Jul 2020 18:43:00 +0300 |
| |
No need to use snprintf() on a constant string, nor using magic constant in the fixed code was a good idea.
Signed-off-by: Sergey Organov <sorganov@gmail.com> --- drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 0c8c56bdd7ac..93a86553147c 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -570,7 +570,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx) int ret; fep->ptp_caps.owner = THIS_MODULE; - snprintf(fep->ptp_caps.name, 16, "fec ptp"); + strlcpy(fep->ptp_caps.name, "fec ptp", sizeof(fep->ptp_caps.name)); fep->ptp_caps.max_adj = 250000000; fep->ptp_caps.n_alarm = 0; -- 2.10.0.1.g57b01a3
| |