Messages in this thread | | | Subject | Re: [PATCH] spi: spidev: Add compatible for external SPI ports on Kontron boards | From | Frieder Schrempf <> | Date | Wed, 15 Jul 2020 13:45:51 +0200 |
| |
On 15.07.20 13:36, Mark Brown wrote: > On Wed, Jul 15, 2020 at 09:26:29AM +0200, Frieder Schrempf wrote: >> On 14.07.20 21:29, Mark Brown wrote: >>> On Tue, Jul 14, 2020 at 10:54:15AM +0200, Frieder Schrempf wrote: > >>>> patch in our own tree, or if a node with a custom compatible string like for >>>> example "kontron,user-spi" would be accepted upstream, without a matching >>>> driver? > >>> I'm having a hard time getting enthusiastic about it TBH - can you not >>> just use spidev and live with the warning? > >> Ok, I can do that, but when I resend my patches and add "compatible = >> 'spidev'" to my DT I expect someone to complain again as my DT does not >> describe the hardware. > > That's the issue with kontron,user-spi too though :/
Yes, true.
> >> But for obvious reasons this can't be considered a good solution and it >> seems somewhat disturbing that the maintainer needs to propose it because of >> lack of proper solutions ;) > > Hey, I proposed other solutions you didn't want to implement!
Right, but you have to admit that the other solutions turned out to be rather out of scope for someone like me who merely wants to use the spidev driver.
But I don't blame you. I'm now having a better idea of how things are (or aren't) supposed to look like. So thanks for your patience!
| |