lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 0/3] um: allow static linking for non-glibc libc implementations
On Sat, Jul 4, 2020 at 1:52 AM Ignat Korchagin <ignat@cloudflare.com> wrote:
>
> This is a continuation of [1]. Since I was able to produce a working UML binary
> with UML_NET_VECTOR linked with musl with the changes included in the patches
> here. I was compiling on Arch Linux, so hopefully all the latest versions of
> the compiler, libraries and binutils.
>
> I also tested allyesconfig with both musl and glibc. The compilation succeeds
> with both, however both binaries (glibc one being dynamically linked) segfault
> on start. This is probably of some incompatible config option/module being
> included and not related to musl/glibc.
>
> [1]: https://patchwork.ozlabs.org/project/linux-um/patch/20200624212319.403689-1-ignat@cloudflare.com/
>
> Ignat Korchagin (3):
> um/kconfig: introduce CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS
> um: some fixes to build UML with musl
> um: allow static linking for non-glibc implementations
>
> arch/um/Kconfig | 2 +-
> arch/um/drivers/Kconfig | 3 ---
> arch/um/drivers/daemon_user.c | 1 +
> arch/um/drivers/pcap_user.c | 12 ++++++------
> arch/um/drivers/slip_user.c | 2 +-
> arch/um/drivers/vector_user.c | 4 +---
> arch/um/os-Linux/util.c | 2 +-
> arch/x86/um/user-offsets.c | 2 +-
> init/Kconfig | 6 ++++++
> scripts/cc-can-link.sh | 5 +++--
> 10 files changed, 21 insertions(+), 18 deletions(-)

Sorry for taking so long to get to this. I saw this last week or
whenever and then forgot, saw the comments yesterday and remembered.

Looks pretty good overall. I will put my reviewed-by on each
individual patch. Nevertheless, I tested them all together, so being
lazy:

Tested-by: Brendan Higgins <brendanhiggins@google.com>

\
 
 \ /
  Last update: 2020-07-15 10:37    [W:0.079 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site