lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *
On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote:
> On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman <
> gregkh@linuxfoundation.org> wrote:
>
> > On Wed, Jul 15, 2020 at 12:48:13AM -0400, B K Karthik wrote:
> > > fixed a sparse warning by changing the type in
> > > assignment from void [noderef] __user * to unsigned int *
> > > (different address space)
> > >
> > > Signed-off-by: B K Karthik <karthik.bk2000@live.com>
> > > ---
> > > drivers/staging/comedi/comedi_fops.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/comedi/comedi_fops.c
> > b/drivers/staging/comedi/comedi_fops.c
> > > index 3f70e5dfac39..4cc012e231b7 100644
> > > --- a/drivers/staging/comedi/comedi_fops.c
> > > +++ b/drivers/staging/comedi/comedi_fops.c
> > > @@ -2956,7 +2956,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
> > > cmd->scan_end_arg = v32.scan_end_arg;
> > > cmd->stop_src = v32.stop_src;
> > > cmd->stop_arg = v32.stop_arg;
> > > - cmd->chanlist = compat_ptr(v32.chanlist);
> > > + cmd->chanlist = (unsigned int *) compat_ptr(v32.chanlist);
> > > cmd->chanlist_len = v32.chanlist_len;
> > > cmd->data = compat_ptr(v32.data);
> > > cmd->data_len = v32.data_len;
> >
> > Always run your patches through checkpatch before sending them, so you
> > do not have a grumpy maintainer telling you that you have to run
> > checkpatch on your patch before sending them.
> >
>
> I will. Sorry for that.
>
> But the error that's being shown in this patch is something that comes up
> on its own.

No it is not.

> git format-patch leaves trailing whitespace in blank lines.

It does? Where is any trailing whitespace here? That's not the issue.

> It has been reported to the maintainers.

It was? Where?

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-07-15 10:32    [W:0.106 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site