Messages in this thread | | | Date | Wed, 15 Jul 2020 09:08:42 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int * |
| |
On Wed, Jul 15, 2020 at 12:48:13AM -0400, B K Karthik wrote: > fixed a sparse warning by changing the type in > assignment from void [noderef] __user * to unsigned int * > (different address space) > > Signed-off-by: B K Karthik <karthik.bk2000@live.com> > --- > drivers/staging/comedi/comedi_fops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > index 3f70e5dfac39..4cc012e231b7 100644 > --- a/drivers/staging/comedi/comedi_fops.c > +++ b/drivers/staging/comedi/comedi_fops.c > @@ -2956,7 +2956,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd, > cmd->scan_end_arg = v32.scan_end_arg; > cmd->stop_src = v32.stop_src; > cmd->stop_arg = v32.stop_arg; > - cmd->chanlist = compat_ptr(v32.chanlist); > + cmd->chanlist = (unsigned int *) compat_ptr(v32.chanlist); > cmd->chanlist_len = v32.chanlist_len; > cmd->data = compat_ptr(v32.data); > cmd->data_len = v32.data_len;
Always run your patches through checkpatch before sending them, so you do not have a grumpy maintainer telling you that you have to run checkpatch on your patch before sending them.
thanks,
greg k-h
| |