lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs
    On Tue, 14 Jul 2020, Kim Phillips wrote:

    > On 7/14/20 4:02 PM, Lee Jones wrote:
    > > On Tue, 14 Jul 2020, Kim Phillips wrote:
    > >> On 7/14/20 9:50 AM, Lee Jones wrote:
    > >>> Can't see them being used anywhere and the compiler doesn't complain
    > >>> that they're missing, so ...
    > >>>
    > >>> Fixes the following W=1 kernel build warning(s):
    > >>>
    > >>> drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=]
    > >>> 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = {
    > >>> | ^~~~~~~~~~~~~~~~~~~~~~~~
    > >>>
    > >>> Cc: Jacob Shin <jacob.shin@amd.com>
    > >>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > >>> ---
    > >>
    > >> Same comment as for patch 9/13: these are used automatic module loading.
    > >
    > > How does that work?
    > >
    > > Could you point me to the code which handles that please?
    >
    > It's MODULE_DEVICE_TABLE magic.

    I'll look into that. Thanks.

    --
    Lee Jones [李琼斯]
    Senior Technical Lead - Developer Services
    Linaro.org │ Open source software for Arm SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2020-07-15 08:47    [W:2.700 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site