Messages in this thread | | | Subject | Re: [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver | From | "David E. Box" <> | Date | Wed, 15 Jul 2020 16:59:02 -0700 |
| |
On Wed, 2020-07-15 at 10:39 +0300, Alexey Budankov wrote: > Hi David, > > On 14.07.2020 9:23, David E. Box wrote:
...
> > > > +static int pmt_telem_open(struct inode *inode, struct file *filp) > > +{ > > + struct pmt_telem_priv *priv; > > + struct pmt_telem_entry *entry; > > + struct pci_driver *pci_drv; > > + struct pci_dev *pci_dev; > > + > > + if (!capable(CAP_SYS_ADMIN)) > > Thanks for supplying these patches. > Are there any reasons not to expose this feature to CAP_PERFMON > privileged > processes too that currently have access to performance monitoring > features > of the kernel without root/CAP_SYS_ADMIN credentials? This could be > done by > pefmon_capable() function call starting from v5.8+.
The new capability is well suited for this feature. I'll make the change. Thanks.
David
| |