lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points
From
Date


On 7/15/20 4:35 AM, Zhang Rui wrote:
> On Fri, 2020-07-10 at 09:51 -0400, Thara Gopinath wrote:
>> For now, thermal governors do not support monitoring of falling
>> temperature. Hence, in case of calls to the governor for trip points
>> marked
>> as cold, return doing nothing.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>> drivers/thermal/gov_bang_bang.c | 8 ++++++++
>> drivers/thermal/gov_fair_share.c | 8 ++++++++
>> drivers/thermal/gov_power_allocator.c | 8 ++++++++
>> drivers/thermal/gov_step_wise.c | 8 ++++++++
>> 4 files changed, 32 insertions(+)
>
> userspace governor does not support cold trip point neither.
>
> So how about adding the check in handle_non_critical_trips first, and
> remove the check later, after all the governors support cold trip?

Yeah, no governors support cold trip for now. Putting check in
handle_non_critical_trips is another way to handle this. I can do it and
come back to this solution when one or more governors start supporting
cold trip points.


--
Warm Regards
Thara

\
 
 \ /
  Last update: 2020-07-16 01:13    [W:0.055 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site