lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RESEND 1/3] usb: gadget: udc: atmel: remove outdated comment in usba_ep_disable()
    On 08/07/2020 20:04:09+0200, Michał Mirosław wrote:
    > Fixed commit removed the offending behaviour from the driver, but missed
    > the comment and associated test. Remove them now.
    >
    > Fixes: 38e58986e6fc ("usb: gadget: udc: atmel: don't disable enpdoints we don't own")
    > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

    > ---
    > drivers/usb/gadget/udc/atmel_usba_udc.c | 8 +-------
    > 1 file changed, 1 insertion(+), 7 deletions(-)
    >
    > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
    > index d69f61ff0181..9153e220848d 100644
    > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
    > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
    > @@ -676,13 +676,7 @@ static int usba_ep_disable(struct usb_ep *_ep)
    >
    > if (!ep->ep.desc) {
    > spin_unlock_irqrestore(&udc->lock, flags);
    > - /* REVISIT because this driver disables endpoints in
    > - * reset_all_endpoints() before calling disconnect(),
    > - * most gadget drivers would trigger this non-error ...
    > - */
    > - if (udc->gadget.speed != USB_SPEED_UNKNOWN)
    > - DBG(DBG_ERR, "ep_disable: %s not enabled\n",
    > - ep->ep.name);
    > + DBG(DBG_ERR, "ep_disable: %s not enabled\n", ep->ep.name);
    > return -EINVAL;
    > }
    > ep->ep.desc = NULL;
    > --
    > 2.20.1
    >

    --
    Alexandre Belloni, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2020-07-15 23:45    [W:4.645 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site