lkml.org 
[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arm64: dts: qcom: sc7180: Add missing properties for Wifi node
On Wed 15 Jul 12:01 PDT 2020, Doug Anderson wrote:

> Hi,
>
> On Sun, Jul 12, 2020 at 9:46 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
> >
> > The wlan firmware memory is statically mapped in
> > the Trusted Firmware, hence the wlan driver does
> > not need to map/unmap this region dynamically.
> >
> > Hence add the property to indicate the wlan driver
> > to not map/unamp the firmware memory region
> > dynamically.
> >
> > Also add the chain1 voltage supply for wlan.
> >
> > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> > ---
> > Changes from v1:
> > - Add the wifi mac alias
> >
> > This patch is created on top of the change by
> > Douglas Anderson.
> > https://lkml.org/lkml/2020/6/25/817
> >
> > Also the dt-bindings for the chain1 voltage supply
> > is added by the below patch series:
> > https://patchwork.kernel.org/project/linux-wireless/list/?series=309137
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 472f7f4..c042d61 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -19,6 +19,7 @@
> >
> > aliases {
> > bluetooth0 = &bluetooth;
> > + wifi0 = &wifi;
> > hsuart0 = &uart3;
> > serial0 = &uart8;
>
> Could you alphabetize?
>

I fixed this up while applying the patch.

Thanks,
Bjorn

> > };
> > @@ -391,10 +392,12 @@
> >
> > &wifi {
> > status = "okay";
> > + qcom,msa-fixed-perm;
> > vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>;
> > vdd-1.8-xo-supply = <&vreg_l1c_1p8>;
> > vdd-1.3-rfa-supply = <&vreg_l2c_1p3>;
> > vdd-3.3-ch0-supply = <&vreg_l10c_3p3>;
> > + vdd-3.3-ch1-supply = <&vreg_l11c_3p3>;
> > wifi-firmware {
> > iommus = <&apps_smmu 0xc2 0x1>;
> > };
>
> Other than the alphabetical order:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

\
 
 \ /
  Last update: 2020-07-15 21:26    [W:0.034 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site