Messages in this thread | | | Date | Tue, 14 Jul 2020 08:35:17 +0200 | From | Greg KH <> | Subject | Re: [PATCH] kobject: remove unused kobject action |
| |
On Mon, Jul 13, 2020 at 09:15:10PM +0200, Garrit Franke wrote: > I noticed that the KOBJ_MAX action is never used. Does it serve any > purpose, or can it be removed?
Don't ask questions in a changelog comment that you don't also answer :)
> As far as I know, Kobjects shouldn't be > used for drivers and more higher level abstraction layers, so I figured > it isn't used by user-provided code either.
Userspace sees these uevents, right?
> > Regards > Garrit Franke
This isn't needed in a changelog text.
Try running and testing this a bit more before sending it for inclusion please.
> > Signed-off-by: Garrit Franke <garritfranke@gmail.com> > --- > include/linux/kobject.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/kobject.h b/include/linux/kobject.h > index 6cba088bee24..fd99c5d2d8b7 100644 > --- a/include/linux/kobject.h > +++ b/include/linux/kobject.h > @@ -58,8 +58,7 @@ enum kobject_action { > KOBJ_ONLINE, > KOBJ_OFFLINE, > KOBJ_BIND, > - KOBJ_UNBIND, > - KOBJ_MAX > + KOBJ_UNBIND
No need to drop that trailing ','
thanks,
greg k-h
| |