Messages in this thread | | | Subject | Re: [PATCH] ASoC: Intel: bytcht_es8316: Add missed put_device() | From | Hans de Goede <> | Date | Tue, 14 Jul 2020 15:33:58 +0200 |
| |
Hi,
On 7/14/20 10:09 AM, Jing Xiangfeng wrote: > snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error > path. Add the missed function call to fix it. > > Fixes: ba49cf6f8e4a ("ASoC: Intel: bytcht_es8316: Add quirk for inverted jack detect") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > sound/soc/intel/boards/bytcht_es8316.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c > index 9e5fc9430628..ecbc58e8a37f 100644 > --- a/sound/soc/intel/boards/bytcht_es8316.c > +++ b/sound/soc/intel/boards/bytcht_es8316.c > @@ -543,8 +543,10 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev) > > if (cnt) { > ret = device_add_properties(codec_dev, props); > - if (ret) > + if (ret) { > + put_device(codec_dev); > return ret; > + } > } > > devm_acpi_dev_add_driver_gpios(codec_dev, byt_cht_es8316_gpios); >
| |