lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
On Mon, Jul 13, 2020 at 07:36:26AM -0700, Tom Rix wrote:
>
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> > #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> > #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> My point about consistency.  These are all intel  and all should have their pf parts removed.
>
> #define PCIE_DEVICE_ID_INTEL_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_INTEL_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_INTEL_DSC_1_X 0x09C4
>
> Let's revisit this for the d5005.

I agree that we should be consistent on the naming. I think we could
reconsider the naming of previous cards and submit a new patch for them.

>
> trix
>

\
 
 \ /
  Last update: 2020-07-14 08:05    [W:0.040 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site