Messages in this thread | | | Date | Tue, 14 Jul 2020 17:18:56 +0800 | From | Can Guo <> | Subject | Re: [PATCH v1 1/2] scsi: ufs: Simplify completion timestamp for SCSI and query commands |
| |
On 2020-07-06 14:07, Stanley Chu wrote: > Simplify recording command completion time in > __ufshcd_transfer_req_compl() by assigning lrbp->compl_time_stamp > in an unified location. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
> --- > drivers/scsi/ufs/ufshcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 18da2d64f9fa..71e8d7c782bd 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4881,6 +4881,7 @@ static void __ufshcd_transfer_req_compl(struct > ufs_hba *hba, > > for_each_set_bit(index, &completed_reqs, hba->nutrs) { > lrbp = &hba->lrb[index]; > + lrbp->compl_time_stamp = ktime_get(); > cmd = lrbp->cmd; > if (cmd) { > ufshcd_add_command_trace(hba, index, "complete"); > @@ -4889,13 +4890,11 @@ static void __ufshcd_transfer_req_compl(struct > ufs_hba *hba, > cmd->result = result; > /* Mark completed command as NULL in LRB */ > lrbp->cmd = NULL; > - lrbp->compl_time_stamp = ktime_get(); > /* Do not touch lrbp after scsi done */ > cmd->scsi_done(cmd); > __ufshcd_release(hba); > } else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE || > lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) { > - lrbp->compl_time_stamp = ktime_get(); > if (hba->dev_cmd.complete) { > ufshcd_add_command_trace(hba, index, > "dev_complete");
| |