Messages in this thread | | | Date | Tue, 14 Jul 2020 09:28:21 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v2 2/2] iommu: Add gfp parameter to io_pgtable_ops->map() |
| |
On Fri, Jun 12, 2020 at 11:39:55AM +0800, Baolin Wang wrote: > Now the ARM page tables are always allocated by GFP_ATOMIC parameter, > but the iommu_ops->map() function has been added a gfp_t parameter by > commit 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map"), > thus io_pgtable_ops->map() should use the gfp parameter passed from > iommu_ops->map() to allocate page pages, which can avoid wasting the > memory allocators atomic pools for some non-atomic contexts. > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +- > drivers/iommu/arm-smmu-v3.c | 2 +- > drivers/iommu/arm-smmu.c | 2 +- > drivers/iommu/io-pgtable-arm-v7s.c | 18 +++++++++--------- > drivers/iommu/io-pgtable-arm.c | 18 +++++++++--------- > drivers/iommu/ipmmu-vmsa.c | 2 +- > drivers/iommu/msm_iommu.c | 2 +- > drivers/iommu/mtk_iommu.c | 2 +- > drivers/iommu/qcom_iommu.c | 2 +- > include/linux/io-pgtable.h | 2 +- > 10 files changed, 26 insertions(+), 26 deletions(-)
I was a bit nervous about us passing GFP_KERNEL with a spinlock held, but it looks like you've checked all the callsites and it looks fine to me, so:
Acked-by: Will Deacon <will@kernel.org>
Joerg -- not sure what you want to do with this one, as it's likely to conflict (trivially) with unrelated driver changes.
Will
| |