Messages in this thread | | | Date | Tue, 14 Jul 2020 09:37:11 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2 1/5] power: supply: core: add quick charge type property |
| |
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
A: No. Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Jul 14, 2020 at 03:31:52PM +0800, ivan wrote: > I think we should add an enumederated for this
What is "this"?
> > for example > > abi document > > What: /sys/class/power_supply/<supply_name>/quick_charge_type > Date: Jul 2020 > Contact: Fei Jiang <jiangfei1@xiaomi.com> > Description: > Reports the kind of quick charge type based on different adapter power. > Different quick charge type represent different charging power. > QUICK_CHARGE_NORMAL : Charging Power <= 10W > QUICK_CHARGE_FAST : 10W < Charging Power <= 20W > QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W > QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W > QUICK_CHARGE_SUPER : Charging Power > 50W > > Access: Read-Only > Valid values: > 0: QUICK_CHARGE_NORMAL, > 1: QUICK_CHARGE_FAST, > 2: QUICK_CHARGE_FLASH, > 3: QUICK_CHARGE_TURBE, > 4: QUICK_CHARGE_SUPER. > > > power_supply.h > > enum power_supply_quick_charge_type { > QUICK_CHARGE_NORMAL = 0, > QUICK_CHARGE_FAST, > QUICK_CHARGE_FLASH, > QUICK_CHARGE_TURBE, > QUICK_CHARGE_SUPER, > QUICK_CHARGE_MAX, > };
That seems like a good change, why not do this? :)
thanks,
greg k-h
| |