Messages in this thread | | | From | Olof Johansson <> | Date | Tue, 14 Jul 2020 20:26:50 -0700 | Subject | Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header |
| |
On Tue, Jul 14, 2020 at 7:50 AM Lee Jones <lee.jones@linaro.org> wrote: > > If function callers and providers do not share the same prototypes the > compiler complains of missing prototypes. Fix this by moving the > already existing prototypes out to a mutually convenient location. > > Fixes the following W=1 kernel build warning(s): > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] > 109 | int check_astate(void) > | ^~~~~~~~~~~~ > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] > 114 | void restore_astate(int cpu) > | ^~~~~~~~~~~~~~ > > Cc: Olof Johansson <olof@lixom.net> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > arch/powerpc/platforms/pasemi/powersave.S | 2 ++ > drivers/cpufreq/pasemi-cpufreq.c | 1 + > include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++++ > 4 files changed, 31 insertions(+), 15 deletions(-) > create mode 100644 include/linux/platform_data/pasemi.h > > diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h > index 70b56048ed1be..528d81ef748ad 100644 > --- a/arch/powerpc/platforms/pasemi/pasemi.h > +++ b/arch/powerpc/platforms/pasemi/pasemi.h > @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); > extern void idle_spin(void); > extern void idle_doze(void); > > -/* Restore astate to last set */ > -#ifdef CONFIG_PPC_PASEMI_CPUFREQ > -extern int check_astate(void); > -extern void restore_astate(int cpu); > -#else > -static inline int check_astate(void) > -{ > - /* Always return >0 so we never power save */ > - return 1; > -} > -static inline void restore_astate(int cpu) > -{ > -} > -#endif > - > extern struct pci_controller_ops pasemi_pci_controller_ops; > > #endif /* _PASEMI_PASEMI_H */ > diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc/platforms/pasemi/powersave.S > index d0215d5329ca7..7747b48963286 100644 > --- a/arch/powerpc/platforms/pasemi/powersave.S > +++ b/arch/powerpc/platforms/pasemi/powersave.S > @@ -5,6 +5,8 @@ > * Maintained by: Olof Johansson <olof@lixom.net> > */ > > +#include <linux/platform_data/pasemi.h> > + > #include <asm/processor.h> > #include <asm/page.h> > #include <asm/ppc_asm.h> > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c > index c66f566a854cb..c6bb3ecc90ef3 100644 > --- a/drivers/cpufreq/pasemi-cpufreq.c > +++ b/drivers/cpufreq/pasemi-cpufreq.c > @@ -15,6 +15,7 @@ > #include <linux/timer.h> > #include <linux/module.h> > #include <linux/of_address.h> > +#include <linux/platform_data/pasemi.h> > > #include <asm/hw_irq.h> > #include <asm/io.h> > diff --git a/include/linux/platform_data/pasemi.h b/include/linux/platform_data/pasemi.h > new file mode 100644 > index 0000000000000..3fed0687fcc9a > --- /dev/null > +++ b/include/linux/platform_data/pasemi.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2020 Linaro Ltd. > + * > + * Author: Lee Jones <lee.jones@linaro.org> > + */
Absolutely not. It's neither your copyright, nor your authorship.
-Olof
| |