lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static
    On 14-07-20, 15:50, Lee Jones wrote:
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes]
    > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]
    >
    > Cc: Michael Ellerman <mpe@ellerman.id.au>
    > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    > Cc: Paul Mackerras <paulus@samba.org>
    > Cc: linuxppc-dev@lists.ozlabs.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/cpufreq/powernv-cpufreq.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
    > index 8646eb197cd96..068cc53abe320 100644
    > --- a/drivers/cpufreq/powernv-cpufreq.c
    > +++ b/drivers/cpufreq/powernv-cpufreq.c
    > @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates)
    > * according quadratic equation. Queues a new timer if it is still not equal
    > * to local pstate
    > */
    > -void gpstate_timer_handler(struct timer_list *t)
    > +static void gpstate_timer_handler(struct timer_list *t)
    > {
    > struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);
    > struct cpufreq_policy *policy = gpstates->policy;
    > @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = {
    > .notifier_call = powernv_cpufreq_reboot_notifier,
    > };
    >
    > -void powernv_cpufreq_work_fn(struct work_struct *work)
    > +static void powernv_cpufreq_work_fn(struct work_struct *work)
    > {
    > struct chip *chip = container_of(work, struct chip, throttle);
    > struct cpufreq_policy *policy;

    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

    --
    viresh

    \
     
     \ /
      Last update: 2020-07-15 05:08    [W:4.582 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site