Messages in this thread | | | Date | Wed, 15 Jul 2020 08:22:49 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block |
| |
On 14-07-20, 15:50, Lee Jones wrote: > There is no need for this to be denoted as kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'attr_set' not described in 'store_sampling_rate' > drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'buf' not described in 'store_sampling_rate' > drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'count' not described in 'store_sampling_rate' > > Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> > Cc: Jun Nakajima <jun.nakajima@intel.com> > Cc: Alexander Clouter <alex@digriz.org.uk> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/cpufreq/cpufreq_governor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index f99ae45efaea7..63f7c219062b9 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -26,7 +26,7 @@ static DEFINE_PER_CPU(struct cpu_dbs_info, cpu_dbs); > static DEFINE_MUTEX(gov_dbs_data_mutex); > > /* Common sysfs tunables */ > -/** > +/*
This is an important routine with good documentation details already there, though internal to governors and so I would rather keep it.
> * store_sampling_rate - update sampling rate effective immediately if needed. > * > * If new rate is smaller than the old, simply updating > -- > 2.25.1
-- viresh
| |