Messages in this thread | | | From | Arvind Sankar <> | Date | Tue, 14 Jul 2020 16:21:00 -0400 | Subject | Re: [PATCH v4 0/7] x86/boot: Remove runtime relocations from compressed kernel |
| |
On Tue, Jul 14, 2020 at 10:08:04PM +0200, Sedat Dilek wrote: > > > > > > In any case, I think the right fix here would be to add -pie and > > > --no-dynamic-linker to LDFLAGS_vmlinux instead of KBUILD_LDFLAGS. > > > > Hmm, you might be right with moving to LDFLAGS_vmlinux. > > > > We will need the "ifndef CONFIG_LD_IS_LLD" as -r and -pie cannot be > used together. > Is that the or not the fact when moving to LDFLAGS_vmlinux?
LDFLAGS_vmlinux will only be used to link boot/compressed/vmlinux, whereas KBUILD_LDFLAGS is used for all linker invocations, and in particular the little link to do the modversions stuff ends up using it.
So once we move -pie --no-dynamic-linker to the more correct LDFLAGS_vmlinux and/or stop modversions running, we'll be fine. Being able to use -pie with lld is one of the goals of this series.
> > I cannot test as I modified my local Git and re-invoking my > build-script is doing a whole new build-dance. > > - Sedat -
| |