lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 085/166] powerpc/64s/exception: Fix 0x1500 interrupt handler crash
    Date
    From: Nicholas Piggin <npiggin@gmail.com>

    [ Upstream commit 4557ac6b344b8cdf948ff8b007e8e1de34832f2e ]

    A typo caused the interrupt handler to branch immediately to the
    common "unknown interrupt" handler and skip the special case test for
    denormal cause.

    This does not affect KVM softpatch handling (e.g., for POWER9 TM
    assist) because the KVM test was moved to common code by commit
    9600f261acaa ("powerpc/64s/exception: Move KVM test to common code")
    just before this bug was introduced.

    Fixes: 3f7fbd97d07d ("powerpc/64s/exception: Clean up SRR specifiers")
    Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
    Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
    Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
    [mpe: Split selftest into a separate patch]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20200708074942.1713396-1-npiggin@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/kernel/exceptions-64s.S | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
    index d9ddce40bed89..fd99d4feec7a4 100644
    --- a/arch/powerpc/kernel/exceptions-64s.S
    +++ b/arch/powerpc/kernel/exceptions-64s.S
    @@ -2547,7 +2547,7 @@ EXC_VIRT_NONE(0x5400, 0x100)
    INT_DEFINE_BEGIN(denorm_exception)
    IVEC=0x1500
    IHSRR=1
    - IBRANCH_COMMON=0
    + IBRANCH_TO_COMMON=0
    IKVM_REAL=1
    INT_DEFINE_END(denorm_exception)

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-14 20:57    [W:4.055 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site