lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 078/166] net: hns3: fix for mishandle of asserting VF reset fail
    Date
    From: Huazhong Tan <tanhuazhong@huawei.com>

    [ Upstream commit cddd5648926d7a6e84526dadd8bfb21609a14fb7 ]

    When asserts VF reset fail, flag HCLGEVF_STATE_CMD_DISABLE
    and handshake status should not set, otherwise the retry will
    fail. So adds a check for asserting VF reset and returns
    directly when fails.

    Fixes: ef5f8e507ec9 ("net: hns3: stop handling command queue while resetting VF")
    Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
    index e02d427131eeb..e6cdd06925e6b 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
    @@ -1527,6 +1527,11 @@ static int hclgevf_reset_prepare_wait(struct hclgevf_dev *hdev)
    if (hdev->reset_type == HNAE3_VF_FUNC_RESET) {
    hclgevf_build_send_msg(&send_msg, HCLGE_MBX_RESET, 0);
    ret = hclgevf_send_mbx_msg(hdev, &send_msg, true, NULL, 0);
    + if (ret) {
    + dev_err(&hdev->pdev->dev,
    + "failed to assert VF reset, ret = %d\n", ret);
    + return ret;
    + }
    hdev->rst_stats.vf_func_rst_cnt++;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-14 20:57    [W:3.924 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site