Messages in this thread | | | Date | Tue, 14 Jul 2020 11:41:37 -0700 | From | Roman Gushchin <> | Subject | Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning |
| |
On Tue, Jul 14, 2020 at 09:46:18PM +0800, Bixuan Cui wrote: > Gcc report the following warning without CONFIG_MEMCG_KMEM: > > mm/percpu-internal.h:145:29: warning: 'pcpu_chunk_type' defined > but not used [-Wunused-function] > static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk) > ^~~~~~~~~~~~~~~ > > Add 'inline' to pcpu_chunk_type(),pcpu_is_memcg_chunk() and > pcpu_chunk_list() to clear warning.
Acked-by: Roman Gushchin <guro@fb.com>
Thank you!
> > Fixes: 26c99879ef01 ("mm: memcg/percpu: account percpu memory to memory cgroups")
The "fixes" tag is not valid: the patch is in the mm queue, so it doesn't have a stable hash. Usually Andrew squashes such fixes into the original patch on merging.
Thanks!
| |