Messages in this thread | | | Date | Mon, 13 Jul 2020 10:30:40 -0300 | From | Bruno Meneguele <> | Subject | Re: [PATCH v2] doc:kmsg: explictly state the return value in case of SEEK_CUR |
| |
On Mon, Jul 13, 2020 at 03:15:09PM +0200, Petr Mladek wrote: > On Mon 2020-07-13 11:25:58, Sergey Senozhatsky wrote: > > On (20/07/10 14:44), Bruno Meneguele wrote: > > > The commit 625d3449788f ("Revert "kernel/printk: add kmsg SEEK_CUR > > > handling"") reverted a change done to the return value in case a SEEK_CUR > > > operation was performed for kmsg buffer based on the fact that different > > > userspace apps were handling the new return value (-ESPIPE) in different > > > ways, breaking them. > > > > > > At the same time -ESPIPE was the wrong decision because kmsg /does support/ > > > seek() but doesn't follow the "normal" behavior userspace is used to. > > > Because of that and also considering the time -EINVAL has been used, it was > > > decided to keep this way to avoid more userspace breakage. > > > > > > This patch adds an official statement to the kmsg documentation pointing to > > > the current return value for SEEK_CUR, -EINVAL, thus userspace libraries > > > and apps can refer to it for a definitive guide on what to expect. > > > > > > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com> > > > > Looks good to me, > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > The patch is committed in printk/linux.git, branch for-5.9. > > Thanks for v2. > > Best Regards, > Petr >
Thanks Sergey and Petr.
-- bmeneg PGP Key: http://bmeneg.com/pubkey.txt [unhandled content-type:application/pgp-signature] | |