Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups | Date | Mon, 13 Jul 2020 14:25:56 +0100 |
| |
On 13/07/20 13:39, Peter Zijlstra wrote: > On Wed, Jul 01, 2020 at 08:06:54PM +0100, Valentin Schneider wrote: >> +/* Generate a mask of SD flags with the SDF_NEEDS_GROUPS metaflag */ >> +#define SD_FLAG(name, idx, mflags) (BIT(idx) * (((mflags) & SDF_NEEDS_GROUPS) / SDF_NEEDS_GROUPS)) | > > #define SD_FLAGS(name, idx, mflags) (!!((mflags) & SDF_NEEDS_GROUPS) * BIT(idx)) >
Was paranoid about really getting a 1 or a 0, but AFAICT the standard does agree with you!
>> +static const int SD_DEGENERATE_GROUPS_MASK = >> +#include<linux/sched/sd_flags.h> >> +0; >> +#undef SD_FLAG >> + >> #ifdef CONFIG_SCHED_DEBUG >> #define SD_FLAG(_name, idx, mflags) [idx] = {.meta_flags = mflags, .name = #_name}, >> static const struct { >> -- >> 2.27.0 >>
| |