Messages in this thread Patch in this message |  | | Subject | Re: [PATCH v6 1/2] hwmon: shtc1: add support for device tree bindings | From | Chris Ruehl <> | Date | Mon, 13 Jul 2020 13:23:09 +0800 |
| |
On 12/7/2020 12:44 pm, Chris Ruehl wrote: > Add support for DTS bindings for the sensirion shtc1,shtw1 and shtc3. > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Received new PCBA from the factory today, with the chip installed. Probe working, the measurement of temperature and humidity is correct.
root@pcba0:~# cat /sys/devices/platform/ff110000.i2c/i2c-1/1-0070/hwmon/hwmon1/temp1_input 42334 root@pcba0:~# cat /sys/devices/platform/ff110000.i2c/i2c-1/1-0070/hwmon/hwmon1/humidity1_input 38128
Tested-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> --- > drivers/hwmon/shtc1.c | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c > index a0078ccede03..7993a5ff8768 100644 > --- a/drivers/hwmon/shtc1.c > +++ b/drivers/hwmon/shtc1.c > @@ -14,6 +14,7 @@ > #include <linux/err.h> > #include <linux/delay.h> > #include <linux/platform_data/shtc1.h> > +#include <linux/of.h> > > /* commands (high precision mode) */ > static const unsigned char shtc1_cmd_measure_blocking_hpm[] = { 0x7C, 0xA2 }; > @@ -196,6 +197,7 @@ static int shtc1_probe(struct i2c_client *client, > enum shtcx_chips chip = id->driver_data; > struct i2c_adapter *adap = client->adapter; > struct device *dev = &client->dev; > + struct device_node *np = dev->of_node; > > if (!i2c_check_functionality(adap, I2C_FUNC_I2C)) { > dev_err(dev, "plain i2c transactions not supported\n"); > @@ -233,8 +235,14 @@ static int shtc1_probe(struct i2c_client *client, > data->client = client; > data->chip = chip; > > - if (client->dev.platform_data) > - data->setup = *(struct shtc1_platform_data *)dev->platform_data; > + if (np) { > + data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io"); > + data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision"); > + } else { > + if (client->dev.platform_data) > + data->setup = *(struct shtc1_platform_data *)dev->platform_data; > + } > + > shtc1_select_command(data); > mutex_init(&data->update_lock); > > @@ -257,8 +265,19 @@ static const struct i2c_device_id shtc1_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, shtc1_id); > > +static const struct of_device_id shtc1_of_match[] = { > + { .compatible = "sensirion,shtc1" }, > + { .compatible = "sensirion,shtw1" }, > + { .compatible = "sensirion,shtc3" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, shtc1_of_match); > + > static struct i2c_driver shtc1_i2c_driver = { > - .driver.name = "shtc1", > + .driver = { > + .name = "shtc1", > + .of_match_table = shtc1_of_match, > + }, > .probe = shtc1_probe, > .id_table = shtc1_id, > }; >
-- GTSYS Limited RFID Technology 9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2, 42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong Tel (852) 9079 9521
Disclaimer: https://www.gtsys.com.hk/email/classified.html
|  |