lkml.org 
[lkml]   [2020]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: r8188eu: remove unused members of struct xmit_buf
From
Date
On 7/12/20 8:55 PM, Larry Finger wrote:
> On 7/12/20 7:38 AM, Ivan Safonov wrote:
>> Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
>> dma_transfer_addr, bpending and last.
>>
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>
> Have you tested this change? Previously with this driver, an unused
> quantity was removed from one of the structs and the driver failed.
> Apparently, the alignment of some other quantity was affected. I do not
> think that this change would have that affect; however, you should be
> testing whenever the changes are more than cosmetic.
>
> Larry
>

I have not tested this patch.

Ivan.

\
 
 \ /
  Last update: 2020-07-12 23:07    [W:0.051 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site