lkml.org 
[lkml]   [2020]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/21] dt-binding: memory: mediatek: Add a common larb-port header file
From
Date


On 11/07/2020 08:48, Yong Wu wrote:
> Put all the macros about smi larb/port togethers, this is a preparing
> patch for extending LARB_NR and adding new dom-id support.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> include/dt-bindings/memory/mt2712-larb-port.h | 2 +-
> include/dt-bindings/memory/mt6779-larb-port.h | 2 +-
> include/dt-bindings/memory/mt8173-larb-port.h | 2 +-
> include/dt-bindings/memory/mt8183-larb-port.h | 2 +-
> include/dt-bindings/memory/mtk-smi-larb-port.h | 15 +++++++++++++++
> 5 files changed, 19 insertions(+), 4 deletions(-)
> create mode 100644 include/dt-bindings/memory/mtk-smi-larb-port.h
>
> diff --git a/include/dt-bindings/memory/mt2712-larb-port.h b/include/dt-bindings/memory/mt2712-larb-port.h
> index 6f9aa7349cef..b6b2c6bf4459 100644
> --- a/include/dt-bindings/memory/mt2712-larb-port.h
> +++ b/include/dt-bindings/memory/mt2712-larb-port.h
> @@ -6,7 +6,7 @@
> #ifndef __DTS_IOMMU_PORT_MT2712_H
> #define __DTS_IOMMU_PORT_MT2712_H
>
> -#define MTK_M4U_ID(larb, port) (((larb) << 5) | (port))
> +#include <dt-bindings/memory/mtk-smi-larb-port.h>
>
> #define M4U_LARB0_ID 0
> #define M4U_LARB1_ID 1
> diff --git a/include/dt-bindings/memory/mt6779-larb-port.h b/include/dt-bindings/memory/mt6779-larb-port.h
> index 2ad0899fbf2f..60f57f54393e 100644
> --- a/include/dt-bindings/memory/mt6779-larb-port.h
> +++ b/include/dt-bindings/memory/mt6779-larb-port.h
> @@ -7,7 +7,7 @@
> #ifndef _DTS_IOMMU_PORT_MT6779_H_
> #define _DTS_IOMMU_PORT_MT6779_H_
>
> -#define MTK_M4U_ID(larb, port) (((larb) << 5) | (port))
> +#include <dt-bindings/memory/mtk-smi-larb-port.h>
>
> #define M4U_LARB0_ID 0
> #define M4U_LARB1_ID 1
> diff --git a/include/dt-bindings/memory/mt8173-larb-port.h b/include/dt-bindings/memory/mt8173-larb-port.h
> index 9f31ccfeca21..d8c99c946053 100644
> --- a/include/dt-bindings/memory/mt8173-larb-port.h
> +++ b/include/dt-bindings/memory/mt8173-larb-port.h
> @@ -6,7 +6,7 @@
> #ifndef __DTS_IOMMU_PORT_MT8173_H
> #define __DTS_IOMMU_PORT_MT8173_H
>
> -#define MTK_M4U_ID(larb, port) (((larb) << 5) | (port))
> +#include <dt-bindings/memory/mtk-smi-larb-port.h>
>
> #define M4U_LARB0_ID 0
> #define M4U_LARB1_ID 1
> diff --git a/include/dt-bindings/memory/mt8183-larb-port.h b/include/dt-bindings/memory/mt8183-larb-port.h
> index 2c579f305162..275c095a6fd6 100644
> --- a/include/dt-bindings/memory/mt8183-larb-port.h
> +++ b/include/dt-bindings/memory/mt8183-larb-port.h
> @@ -6,7 +6,7 @@
> #ifndef __DTS_IOMMU_PORT_MT8183_H
> #define __DTS_IOMMU_PORT_MT8183_H
>
> -#define MTK_M4U_ID(larb, port) (((larb) << 5) | (port))
> +#include <dt-bindings/memory/mtk-smi-larb-port.h>
>
> #define M4U_LARB0_ID 0
> #define M4U_LARB1_ID 1
> diff --git a/include/dt-bindings/memory/mtk-smi-larb-port.h b/include/dt-bindings/memory/mtk-smi-larb-port.h
> new file mode 100644
> index 000000000000..2ec7fe5ce4e9
> --- /dev/null
> +++ b/include/dt-bindings/memory/mtk-smi-larb-port.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (c) 2020 MediaTek Inc.
> + * Author: Yong Wu <yong.wu@mediatek.com>
> + */
> +#ifndef __DTS_MTK_IOMMU_PORT_H_
> +#define __DTS_MTK_IOMMU_PORT_H_
> +
> +#define MTK_LARB_NR_MAX 16

include/soc/mediatek/smi.h has the very same define.
Should smi.h include this file?

Regards,
Matthias

> +
> +#define MTK_M4U_ID(larb, port) (((larb) << 5) | (port))
> +#define MTK_M4U_TO_LARB(id) (((id) >> 5) & 0xf)
> +#define MTK_M4U_TO_PORT(id) ((id) & 0x1f)
> +
> +#endif
>

\
 
 \ /
  Last update: 2020-07-12 20:06    [W:0.181 / U:2.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site