lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] regmap: Switch to use fwnode instead of OF one
On Fri, Jul 10, 2020 at 05:13:06PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 10, 2020 at 4:36 PM Mark Brown <broonie@kernel.org> wrote:

> > Oh, I see your patch covered a different bit of code without covering
> > the stuff in regmap-irq (which I'd just handled when your patch came in)
> > for some reason so the changelog made it sound like the same code, and
> > at the time you submitted it the patch was incomplete.

> Should I do anything to improve it?

Ideally the changelog should have been more clear that it was a partial
conversion (and which bits of the code it was covering), that'd have
made it more obvious that it was covering more/different stuff to the
other patch.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-10 18:23    [W:0.041 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site