Messages in this thread | | | Date | Fri, 10 Jul 2020 17:22:20 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1] regmap: Switch to use fwnode instead of OF one |
| |
On Fri, Jul 10, 2020 at 05:13:06PM +0300, Andy Shevchenko wrote: > On Fri, Jul 10, 2020 at 4:36 PM Mark Brown <broonie@kernel.org> wrote:
> > Oh, I see your patch covered a different bit of code without covering > > the stuff in regmap-irq (which I'd just handled when your patch came in) > > for some reason so the changelog made it sound like the same code, and > > at the time you submitted it the patch was incomplete.
> Should I do anything to improve it?
Ideally the changelog should have been more clear that it was a partial conversion (and which bits of the code it was covering), that'd have made it more obvious that it was covering more/different stuff to the other patch. [unhandled content-type:application/pgp-signature] | |