Messages in this thread | | | Subject | Re: [PATCH v14 07/20] mm/thp: narrow lru locking | From | Alex Shi <> | Date | Fri, 10 Jul 2020 22:09:42 +0800 |
| |
在 2020/7/10 下午7:28, Kirill A. Shutemov 写道: >> * hugetlb_fault_mutex (hugetlbfs specific page fault mutex) >> * anon_vma->rwsem >> * mm->page_table_lock or pte_lock >> - * pgdat->lru_lock (in mark_page_accessed, isolate_lru_page) >> * swap_lock (in swap_duplicate, swap_info_get) >> * mmlist_lock (in mmput, drain_mmlist and others) >> * mapping->private_lock (in __set_page_dirty_buffers) >> - * mem_cgroup_{begin,end}_page_stat (memcg->move_lock) >> + * lock_page_memcg move_lock (in __set_page_dirty_buffers) >> * i_pages lock (widely used) >> + * lock_page_lruvec_irq lruvec->lru_lock > I think it has to be > lruvec->lru_lock (in lock_page_lruvec_irq)
Good catch! I will update it in next version. Thanks!
> > No?
> >> * inode->i_lock (in set_page_dirty's __mark_inode_dirty) >> * bdi.wb->list_lock (in set_page_dirty's __mark_inode_dirty) >> * sb_lock (within inode_lock in fs/fs-writeback.c) >> >>> local_irq_disable() also deserves a comment. >>> >> yes, I will add a comment for this. Do you mind give reviewed-by for this patch? > Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Thanks a lot! :)
| |