lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v14 07/20] mm/thp: narrow lru locking
From
Date


在 2020/7/10 下午7:28, Kirill A. Shutemov 写道:
>> * hugetlb_fault_mutex (hugetlbfs specific page fault mutex)
>> * anon_vma->rwsem
>> * mm->page_table_lock or pte_lock
>> - * pgdat->lru_lock (in mark_page_accessed, isolate_lru_page)
>> * swap_lock (in swap_duplicate, swap_info_get)
>> * mmlist_lock (in mmput, drain_mmlist and others)
>> * mapping->private_lock (in __set_page_dirty_buffers)
>> - * mem_cgroup_{begin,end}_page_stat (memcg->move_lock)
>> + * lock_page_memcg move_lock (in __set_page_dirty_buffers)
>> * i_pages lock (widely used)
>> + * lock_page_lruvec_irq lruvec->lru_lock
> I think it has to be
> lruvec->lru_lock (in lock_page_lruvec_irq)

Good catch! I will update it in next version.
Thanks!

>
> No?

>
>> * inode->i_lock (in set_page_dirty's __mark_inode_dirty)
>> * bdi.wb->list_lock (in set_page_dirty's __mark_inode_dirty)
>> * sb_lock (within inode_lock in fs/fs-writeback.c)
>>
>>> local_irq_disable() also deserves a comment.
>>>
>> yes, I will add a comment for this. Do you mind give reviewed-by for this patch?
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Thanks a lot! :)

\
 
 \ /
  Last update: 2020-07-10 16:11    [W:0.062 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site