Messages in this thread | | | From | Yafang Shao <> | Date | Fri, 10 Jul 2020 22:04:07 +0800 | Subject | Re: [PATCH v2] mm, oom: make the calculation of oom badness more accurate |
| |
On Fri, Jul 10, 2020 at 9:07 PM Michal Hocko <mhocko@kernel.org> wrote: > > On Fri 10-07-20 14:58:54, Michal Hocko wrote: > [...] > > I will have a closer look. Is the full dmesg available somewhere? > > Ups, I have missed this: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 2dd5a90f2f81..7f01835862f4 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -306,7 +306,7 @@ static enum oom_constraint constrained_alloc(struct oom_control *oc) > static int oom_evaluate_task(struct task_struct *task, void *arg) > { > struct oom_control *oc = arg; > - unsigned long points; > + long points; > > if (oom_unkillable_task(task)) > goto next; > > Does it help? > --
Thanks Michal. This should be the fix. I did it in our in-house kernel, but when I posted it to upstream I missed it. That's my fault.
-- Thanks Yafang
| |