Messages in this thread | | | Subject | Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters | From | Paolo Bonzini <> | Date | Fri, 10 Jul 2020 09:48:31 +0200 |
| |
On 23/06/20 17:31, Christian Borntraeger wrote: > > I have trouble seeing value in this particular patch. We add LOCs > without providing any noticable benefit. All other patches in this series at > least reduce the amount of code. So I would defer this to Paolo if he prefers > to have this way across all architectures.
Yes, it adds lines of code but they're just
+ struct kvm_run *kvm_run = vcpu->run;
You could avoid the LoC increase by repeating vcpu->run over and over, but I think the code overall is clearer.
Paolo
| |