lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] stmmac: pci: Add support for LS7A bridge chip
From
Date


在 2020/7/10 16:51, Zhi Li 写道:
> Add gmac platform data to support LS7A bridge chip.
>
> Co-developed-by: Hongbin Li <lihongbin@loongson.cn>
> Signed-off-by: Hongbin Li <lihongbin@loongson.cn>
> Signed-off-by: Zhi Li <lizhi01@loongson.cn>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
> index 272cb47..dab2a40 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
> @@ -138,6 +138,24 @@ static const struct stmmac_pci_info snps_gmac5_pci_info = {
> .setup = snps_gmac5_default_data,
> };
>
> +static int loongson_default_data(struct pci_dev *pdev, struct plat_stmmacenent_data *plat)
> +{
> + common_default_data(plat);
> +
> + plat->bus_id = pci_dev_id(pdev);
> + plat->phy_addr = 0;
> + plat->interface = PHY_INTERFACE_MODE_GMII;
> +
> + plat->dma_cfg->pbl = 32;
> + plat->dma_cfg->pblx8 = true;
> +
> + return 0;
> +}
> +
> +static struct stmmac_pci_info loongson_pci_info = {
> + .setup = loongson_default_data;
> +};
> +
> /**
> * stmmac_pci_probe
> *
> @@ -204,6 +222,8 @@ static int stmmac_pci_probe(struct pci_dev *pdev,
> res.addr = pcim_iomap_table(pdev)[i];
> res.wol_irq = pdev->irq;
> res.irq = pdev->irq;
> + if (pdev->vendor == PCI_VENDOR_ID_LOONGSON)
> + res.lpi_irq = pdev->irq + 1;

This can never work.
We're allocating IRQs by irq_domain, not ID.
Please describe IRQ in DeviceTree, and *DO NOT* sne dout untested patch.

Thanks.

>
> return stmmac_dvr_probe(&pdev->dev, plat, &res);
> }
> @@ -273,11 +293,13 @@ static SIMPLE_DEV_PM_OPS(stmmac_pm_ops, stmmac_pci_suspend, stmmac_pci_resume);
>
> #define PCI_DEVICE_ID_STMMAC_STMMAC 0x1108
> #define PCI_DEVICE_ID_SYNOPSYS_GMAC5_ID 0x7102
> +#define PCI_DEVICE_ID_LOONGSON_GMAC 0x7a03
>
> static const struct pci_device_id stmmac_id_table[] = {
> { PCI_DEVICE_DATA(STMMAC, STMMAC, &stmmac_pci_info) },
> { PCI_DEVICE_DATA(STMICRO, MAC, &stmmac_pci_info) },
> { PCI_DEVICE_DATA(SYNOPSYS, GMAC5_ID, &snps_gmac5_pci_info) },
> + { PCI_DEVICE_DATA(LOONGSON, GMAC, &loongson_pci_info) },
> {}
> };
>
- Jiaxun

\
 
 \ /
  Last update: 2020-07-11 03:45    [W:0.068 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site