Messages in this thread | | | Subject | Re: [PATCH 5/11 RFC] PCI: pciehp: Make "Power On" the default | From | Saheed Bolarinwa <> | Date | Fri, 10 Jul 2020 23:42:12 +0200 |
| |
On 7/10/20 2:14 AM, Bjorn Helgaas wrote: > On Mon, Jul 06, 2020 at 11:31:15AM +0200, Saheed Olayemi Bolarinwa wrote: >> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com> >> >> The default case of the switch statement is redundant since >> PCI_EXP_SLTCTL_PCC is only a single bit. pcie_capability_read_word() >> currently causes "On" value to be set if it fails. Patch 11/11 >> changes the behaviour of pcie_capability_read_word() so on falure the >> "Off" value will be set. > s/falure/failure/ > > Split this into two patches. The removal of the default case should > be in its own patch to make it trivial to review. > Thank you for the review. It is now split into two in the version 3 which I just sent.
- Saheed
| |