lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 03/17] arm64: Allow IPIs to be handled as normal interrupts
    Date

    Itsy bitsy nit below from re-reading this.

    On 24/06/20 20:57, Marc Zyngier wrote:
    > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
    > index e43a8ff19f0f..c08950cc09cc 100644
    > --- a/arch/arm64/kernel/smp.c
    > +++ b/arch/arm64/kernel/smp.c
    > @@ -76,6 +76,13 @@ enum ipi_msg_type {
    > IPI_WAKEUP
    > };
    >
    > +static int ipi_irq_base;
    > +static int nr_ipi = NR_IPI;

    If we really care, these two could be marked as __read_mostly.

    > +static struct irq_desc *ipi_desc[NR_IPI];
    > +
    > +static void ipi_setup(int cpu);
    > +static void ipi_teardown(int cpu);
    > +
    > #ifdef CONFIG_HOTPLUG_CPU
    > static int op_cpu_kill(unsigned int cpu);
    > #else

    \
     
     \ /
      Last update: 2020-07-10 21:59    [W:3.503 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site