lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header
From
Date
On 7/1/20 8:46 AM, Ben Widawsky wrote:
>> +/*
>> + * These bit locations are exposed in the vm.zone_reclaim_mode sysctl
>> + * ABI. New bits are OK, but existing bits can never change.
>> + */
>> +#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
>> +#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
>> +#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
> Have you considered turning this into an enum while moving it?

The thought occurred to me, but all of the other bits in the uapi file
were defined this way. I decided to not not attempt to buck the trend
in their new home.

\
 
 \ /
  Last update: 2020-07-01 17:57    [W:0.046 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site