Messages in this thread | | | Subject | Re: [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header | From | Dave Hansen <> | Date | Wed, 1 Jul 2020 08:56:25 -0700 |
| |
On 7/1/20 8:46 AM, Ben Widawsky wrote: >> +/* >> + * These bit locations are exposed in the vm.zone_reclaim_mode sysctl >> + * ABI. New bits are OK, but existing bits can never change. >> + */ >> +#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */ >> +#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */ >> +#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */ > Have you considered turning this into an enum while moving it?
The thought occurred to me, but all of the other bits in the uapi file were defined this way. I decided to not not attempt to buck the trend in their new home.
| |