Messages in this thread | | | Date | Wed, 1 Jul 2020 20:34:12 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state |
| |
On 01-07-20, 14:20, Charles Keepax wrote: > On Mon, Jun 29, 2020 at 07:17:37PM +0530, Vinod Koul wrote: > > On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING > > state, so set that for partially draining streams in > > snd_compr_drain_notify() and use a flag for partially draining streams > > > > While at it, add locks for stream state change in > > snd_compr_drain_notify() as well. > > > > Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)") > > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > Worth noting I haven't actually tested the gapless, but keeps all > the compressed capture stuff happy.
Thanks for testing and review Charles.
Btw Srini is adding support to fcplay so that we can do gapless testing without using HALs/players. Now that we have an public board (RB3) where compress works out of box, we should build more things on top :)
-- ~Vinod
| |