Messages in this thread | | | Date | Wed, 1 Jul 2020 14:20:32 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state |
| |
On Mon, Jun 29, 2020 at 07:17:37PM +0530, Vinod Koul wrote: > On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING > state, so set that for partially draining streams in > snd_compr_drain_notify() and use a flag for partially draining streams > > While at it, add locks for stream state change in > snd_compr_drain_notify() as well. > > Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)") > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > ---
Worth noting I haven't actually tested the gapless, but keeps all the compressed capture stuff happy.
Tested-by: Charles Keepax <ckeepax@opensource.cirrus.com> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks, Charles
| |