lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] usb: cdns3: Improvement: changed return type from int to bool
    Date
    Patch changes return type from int to bool for
    cdns3_is_host and cdns3_is_device functions.

    Signed-off-by: Pawel Laszczak <pawell@cadence.com>
    ---
    drivers/usb/cdns3/drd.c | 16 ++++++++--------
    drivers/usb/cdns3/drd.h | 4 ++--
    2 files changed, 10 insertions(+), 10 deletions(-)

    diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
    index 05a9f7d54c46..6fe092c828b3 100644
    --- a/drivers/usb/cdns3/drd.c
    +++ b/drivers/usb/cdns3/drd.c
    @@ -83,25 +83,25 @@ int cdns3_get_vbus(struct cdns3 *cdns)
    return vbus;
    }

    -int cdns3_is_host(struct cdns3 *cdns)
    +bool cdns3_is_host(struct cdns3 *cdns)
    {
    if (cdns->dr_mode == USB_DR_MODE_HOST)
    - return 1;
    + return true;
    else if (!cdns3_get_id(cdns))
    - return 1;
    + return true;

    - return 0;
    + return false;
    }

    -int cdns3_is_device(struct cdns3 *cdns)
    +bool cdns3_is_device(struct cdns3 *cdns)
    {
    if (cdns->dr_mode == USB_DR_MODE_PERIPHERAL)
    - return 1;
    + return true;
    else if (cdns->dr_mode == USB_DR_MODE_OTG)
    if (cdns3_get_id(cdns))
    - return 1;
    + return true;

    - return 0;
    + return false;
    }

    /**
    diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h
    index 04e01c4d2377..35b6d459ee58 100644
    --- a/drivers/usb/cdns3/drd.h
    +++ b/drivers/usb/cdns3/drd.h
    @@ -153,8 +153,8 @@ struct cdns3_otg_common_regs {
    /* Only for CDNS3_CONTROLLER_V0 version */
    #define OVERRIDE_IDPULLUP_V0 BIT(24)

    -int cdns3_is_host(struct cdns3 *cdns);
    -int cdns3_is_device(struct cdns3 *cdns);
    +bool cdns3_is_host(struct cdns3 *cdns);
    +bool cdns3_is_device(struct cdns3 *cdns);
    int cdns3_get_id(struct cdns3 *cdns);
    int cdns3_get_vbus(struct cdns3 *cdns);
    int cdns3_drd_init(struct cdns3 *cdns);
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-07-01 08:25    [W:6.257 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site