lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 4/4] net: macb: remove is_udp variable
    Date
    Remove is_udp variable that is used in only one place and use
    ip_hdr(skb)->protocol == IPPROTO_UDP check instead.

    Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    ---
    drivers/net/ethernet/cadence/macb_main.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
    index 3603ab707e0f..4e7317747f54 100644
    --- a/drivers/net/ethernet/cadence/macb_main.c
    +++ b/drivers/net/ethernet/cadence/macb_main.c
    @@ -1933,7 +1933,7 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
    unsigned long flags;
    unsigned int desc_cnt, nr_frags, frag_size, f;
    unsigned int hdrlen;
    - bool is_lso, is_udp = 0;
    + bool is_lso;
    netdev_tx_t ret = NETDEV_TX_OK;

    if (macb_clear_csum(skb)) {
    @@ -1949,10 +1949,8 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
    is_lso = (skb_shinfo(skb)->gso_size != 0);

    if (is_lso) {
    - is_udp = !!(ip_hdr(skb)->protocol == IPPROTO_UDP);
    -
    /* length of headers */
    - if (is_udp)
    + if (ip_hdr(skb)->protocol == IPPROTO_UDP)
    /* only queue eth + ip headers separately for UDP */
    hdrlen = skb_transport_offset(skb);
    else
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-07-01 15:10    [W:3.531 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site