Messages in this thread | | | Date | Wed, 1 Jul 2020 13:50:55 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH][next] thunderbolt: ensure left shift of 512 does not overflow a 32 bit int |
| |
On Tue, Jun 30, 2020 at 03:55:58PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The 32 bit int value 512 is being left shifted and then used in a context > that expects the expression to be a larger unsigned long. There may be > a potential integer overflow, so make 512 a UL before shift to avoid > any such issues. > > Addresses-Coverity: ("Uninintentional integer overflow") > Fixes: 3b1d8d577ca8 ("thunderbolt: Implement USB3 bandwidth negotiation routines") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks!
| |