lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 16/30] misc: mic: scif: scif_ports: Fix copy 'n' paste error
    Date
    __scif_get_port() has never taken 'port' as an argument since
    its inception back in 2015. Probably document the proper arguments
    expected 'start' and 'end'.

    Fixes the following W=1 kernel build warnings:

    drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'start' not described in '__scif_get_port
    drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'end' not described in '__scif_get_port'
    drivers/misc/mic/scif/scif_ports.c:36: warning: Excess function parameter 'port' description in '__scif_get_port'

    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/misc/mic/scif/scif_ports.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/misc/mic/scif/scif_ports.c b/drivers/misc/mic/scif/scif_ports.c
    index 547a71285069a..4bdb5ef9a1399 100644
    --- a/drivers/misc/mic/scif/scif_ports.c
    +++ b/drivers/misc/mic/scif/scif_ports.c
    @@ -14,11 +14,11 @@

    struct idr scif_ports;

    -/*
    +/**
    * struct scif_port - SCIF port information
    *
    - * @ref_cnt - Reference count since there can be multiple endpoints
    - * created via scif_accept(..) simultaneously using a port.
    + * @ref_cnt: Reference count since there can be multiple endpoints
    + * created via scif_accept(..) simultaneously using a port.
    */
    struct scif_port {
    int ref_cnt;
    @@ -27,7 +27,8 @@ struct scif_port {
    /**
    * __scif_get_port - Reserve a specified port # for SCIF and add it
    * to the global list.
    - * @port : port # to be reserved.
    + * @start: lowest port # to be reserved (inclusive).
    + * @end: highest port # to be reserved (exclusive).
    *
    * @return : Allocated SCIF port #, or -ENOSPC if port unavailable.
    * On memory allocation failure, returns -ENOMEM.
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-01 10:33    [W:3.893 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site