Messages in this thread | | | From | Andy Lutomirski <> | Subject | Re: objtool clac/stac handling change.. | Date | Wed, 1 Jul 2020 20:08:36 -0700 |
| |
> On Jul 1, 2020, at 7:30 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Wed, Jul 1, 2020 at 5:48 PM Andy Lutomirski <luto@kernel.org> wrote: >> >> You inspired me to mock it up. > > Ahh, you want to just use the jump folding of gcc to avoid the problem. > > I guess we could do that. Are there cases where this actually helps? >
I was thinking it would help avoid brain melt. For better or for worse, the kernel is written in C, and readers don’t really expect call_some_function(arg, other arg) to actually teleport elsewhere in the function. I’m all for goto err; but at least that’s spelled “goto” and it’s really obvious what it does.
| |