Messages in this thread | | | Subject | Re: [PATCH v2 1/6] powerpc/pseries/iommu: Create defines for operations in ibm,ddw-applicable | From | Leonardo Bras <> | Date | Wed, 01 Jul 2020 21:36:12 -0300 |
| |
On Thu, 2020-07-02 at 10:21 +1000, Alexey Kardashevskiy wrote: > > enum { > > DDW_QUERY_PE_DMA_WIN, > > DDW_CREATE_PE_DMA_WIN, > > DDW_REMOVE_PE_DMA_WIN, > > > > DDW_APPLICABLE_SIZE > > } > > IMO, it looks better than all the defines before. > > > > What do you think? > > No, not really, these come from a binary interface so the reader of this > cares about absolute numbers and rather wants to see them explicitly.
Makes sense to me. I am still getting experience on where to use enum vs define. Thanks for the tip!
Using something like enum { DDW_QUERY_PE_DMA_WIN = 0, DDW_CREATE_PE_DMA_WIN = 1, DDW_REMOVE_PE_DMA_WIN = 2,
DDW_APPLICABLE_SIZE };
would be fine too? Or should one stick to #define in this case?
Thank you,
| |