lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: algo-pca: Add 0x78 as SCL stuck low status

> Any conclusion on this? I'm still suggesting that just treating 0x78
> and 0x90 as SCL stuck for either chip is the cleanest solution. I
> think I could do something with a fall-through that repeats the check
> with an if which wouldn't be too ugly.

I tried as well and also came up with code which was not very readable
while trying to be clever.

So, I agree. Let's keep things simple and take your original approach.
Can you resend the patch and update the comments to reflect which code
is for which version? And include the other paragraph in your commit
message?

Thanks!

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-02 00:30    [W:0.269 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site