Messages in this thread | | | Subject | Re: [PATCH v6 3/6] mm/workingset: extend the workingset detection for anon LRU | From | Vlastimil Babka <> | Date | Wed, 1 Jul 2020 23:25:10 +0200 |
| |
On 6/17/20 7:26 AM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Hi,
I would adjust the subject, as it sounds like the patch does the whole workingset detection, not just preparation. How about:
mm/workingset: prepare the workingset infrastructure for anon LRU
> In the following patch, workingset detection will be applied to > anonymous LRU. To prepare it, this patch adds some code to > distinguish/handle the both LRUs.
How about: To prepare for this, this patch splits workingset event counters for refault, activate and restore into anon and file variants, as well as the refaults counter in struct lruvec.
> v6: do not introduce a new nonresident_age for anon LRU since > we need to use *unified* nonresident_age to implement workingset > detection for anon LRU.
Again, v6 update info shouldn't go to changelog. In this case I think it doesn't need mentioning at all, at least not in this patch.
> Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
| |