Messages in this thread | | | Date | Wed, 1 Jul 2020 21:39:20 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage |
| |
On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just remove this variable since it was > actually unused:
Please copy maintainers on patches :(
Acked-by: Mark Brown <broonie@kernel.org> [unhandled content-type:application/pgp-signature] | |