lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 17/41] net/mlx5e: replace EINVAL in mlx5e_flower_parse_meta()
    Date
    From: Pablo Neira Ayuso <pablo@netfilter.org>

    [ Upstream commit a683012a8e77675a1947cc8f11f97cdc1d5bb769 ]

    The drivers reports EINVAL to userspace through netlink on invalid meta
    match. This is confusing since EINVAL is usually reserved for malformed
    netlink messages. Replace it by more meaningful codes.

    Fixes: 6d65bc64e232 ("net/mlx5e: Add mlx5e_flower_parse_meta support")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
    @@ -1824,7 +1824,7 @@ static int mlx5e_flower_parse_meta(struc
    flow_rule_match_meta(rule, &match);
    if (match.mask->ingress_ifindex != 0xFFFFFFFF) {
    NL_SET_ERR_MSG_MOD(extack, "Unsupported ingress ifindex mask");
    - return -EINVAL;
    + return -EOPNOTSUPP;
    }

    ingress_dev = __dev_get_by_index(dev_net(filter_dev),
    @@ -1832,13 +1832,13 @@ static int mlx5e_flower_parse_meta(struc
    if (!ingress_dev) {
    NL_SET_ERR_MSG_MOD(extack,
    "Can't find the ingress port to match on");
    - return -EINVAL;
    + return -ENOENT;
    }

    if (ingress_dev != filter_dev) {
    NL_SET_ERR_MSG_MOD(extack,
    "Can't match on the ingress filter port");
    - return -EINVAL;
    + return -EOPNOTSUPP;
    }

    return 0;

    \
     
     \ /
      Last update: 2020-06-09 19:56    [W:4.343 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site